Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15417#discussion_r85654895
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FilterPushdownSuite.scala
---
@@ -1016,6 +1016,8 @@ class FilterPushdownSuite extends PlanTest {
val correctAnswer = x.where("x.a".attr === 5).join(y.where("y.a".attr
=== 5),
condition = Some("x.a".attr === Rand(10) && "y.b".attr === 5))
- comparePlans(Optimize.execute(originalQuery.analyze),
correctAnswer.analyze)
--- End diff --
Filter is allowed to have nondeterministic condition.
For Join, actually the rule to handle nondeterministic condition is
unnecessary, as join condition is always deterministic, we can remove these
logic in the optimizer rule and its corresponding tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
