Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15417#discussion_r85692528
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SimplifyCastsSuite.scala
---
@@ -44,7 +44,9 @@ class SimplifyCastsSuite extends PlanTest {
val input = LocalRelation('a.array(ArrayType(IntegerType, true)))
val plan = input.select('a.cast(ArrayType(IntegerType,
false)).as("casted")).analyze
val optimized = Optimize.execute(plan)
- comparePlans(optimized, plan)
+ // Though cast from `ArrayType(IntegerType, true)` to
`ArrayType(IntegerType, false)` is not
+ // allowed, here we just ensure that `SimplifyCasts` rule respect the
plan.
+ comparePlans(optimized, plan, checkAnalysis = false)
--- End diff --
LGTM. As a comment pointed out, this test do not expect the plan is
executed correctly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
