Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15671#discussion_r85766484
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -284,6 +288,7 @@ class GeneralizedLinearRegression @Since("2.0.0")
(@Since("2.0.0") override val
.setParent(this))
val trainingSummary = new
GeneralizedLinearRegressionTrainingSummary(dataset, model,
irlsModel.diagInvAtWA.toArray, irlsModel.numIterations, getSolver)
+ instr.logSuccess(model)
--- End diff --
We need to log success if we enter the `WeightedLeastSquares` branch above
as well. Maybe we can refactor the code to use `if else` instead of an `if`
with a `return`. That way we only need to log success in one place.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
