Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15671#discussion_r85763275
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/AFTSurvivalRegression.scala
---
@@ -276,6 +280,7 @@ class AFTSurvivalRegression @Since("1.6.0")
(@Since("1.6.0") override val uid: S
val intercept = parameters(1)
val scale = math.exp(parameters(0))
val model = new AFTSurvivalRegressionModel(uid, coefficients,
intercept, scale)
+ instr.logSuccess(model)
--- End diff --
minor: move the `logSuccess` call after the `copyValues`. That way if we
ever do something in `logSuccess` like logging parameters of the model, the
call will reflect the copied parameters.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
