Github user vlad17 commented on the issue:
https://github.com/apache/spark/pull/14547
@jkbradley There seems to be more issues with deprecating impurity:
[error] [warn]
/home/jenkins/workspace/SparkPullRequestBuilder/mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala:114:
method setImpurity overrides concrete, non-deprecated symbol(s): setImpurity
[error] [warn] override def setImpurity(value: String): this.type =
super.setImpurity(value)
[error] [warn]
[error] [warn]
/home/jenkins/workspace/SparkPullRequestBuilder/mllib/src/main/scala/org/apache/spark/ml/regression/GBTRegressor.scala:111:
method setImpurity overrides concrete, non-deprecated symbol(s): setImpurity
[error] [warn] override def setImpurity(value: String): this.type =
super.setImpurity(value)
[error] [warn]
The shared superclass for GBT* (Tree*Params) can't have setImpurity
deprecated because it's shared with derived classes that should allow
impurity-setting, and therefore can't have the base class method deprecated. I
find it weird that a derived class can't add a deprecation, though. Why is that
rule there? Can I disable it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
