Github user sethah commented on the issue:

    https://github.com/apache/spark/pull/15671
  
    So, if we consistently use `instr.logParams(params: _*)` (even in cases 
where it's acceptable) then we run the risk of adding some param in the future 
that could "overload" the logs (like initialModel). However, if we manually 
select the appropriate params to log, then we risk adding some other param in 
the future which we do want to log, but it never gets added. Both could be 
problematic.
    
    For now, I think I lean towards manually selecting which params to log 
rather than logging all params. If we add more params later we will have to 
remember to add them to the logging. What are others' thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to