Github user mridulm commented on the pull request:
https://github.com/apache/spark/pull/2187#issuecomment-53929367
I don't have my workspace handy, but search for revert usages ... That
should answer where it is called.
Since I added the error handling, I am fairly certain you will have revert
after close in case of issues : not doing this actually breaks consolidated
shuffle (1.0 behavior)
On 29-Aug-2014 11:52 pm, "andrewor14" <[email protected]> wrote:
> Maybe I'm missing something, but I don't see a way for the writer to be
> reverted after close() is called. The only place to revert the writes is
> through revertPartialWritesAndClose(), but this should not be called
> after close() anyway. Perhaps we should add some safeguard against
> calling anything else in this class after we call close(), but as far as
> I'm concerned the existing code is correct since we don't use
> reportedPosition again after close(), so there is no need to update it.
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/2187#issuecomment-53912516>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
