Github user mridulm commented on the pull request:
https://github.com/apache/spark/pull/2187#issuecomment-53929877
Writers are not thread safe, so that is fine.
Updating reportedPosition might be sufficient; a naive analysis did suggest
that was minimal change required to this pr.
But this is slightly involved code reused in various forms; with extremely
minimal testcases ... Hence why we need to be very careful making changes
to it (similar to the mess that is Connection/ConnectionManager).
On 29-Aug-2014 10:25 pm, "Marcelo Vanzin" <[email protected]> wrote:
> After a second look, close seems to be idempotent (albeit not thread-safe,
> but that's ok?). So it seems that the only problem is not updating
> reportedPosition in commitAndClose()?
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/2187#issuecomment-53902159>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
