Github user ajbozarth commented on the issue:

    https://github.com/apache/spark/pull/15742
  
    Nice catch, from a quick look this seems good. My issue is one of 
consistency, in previous changes I've made I've used a setter rather that 
declaring a var on the scala side. I think using a default val and a setter is 
safer than checking for undefined. An example can be seen at the top of 
`historyserver.js`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to