Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15742#discussion_r86646314
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala ---
@@ -275,6 +277,79 @@ class HistoryServerSuite extends SparkFunSuite with
BeforeAndAfter with Matchers
all (siteRelativeLinks) should startWith (uiRoot)
}
+ test("ajax rendered relative links are prefixed with uiRoot
(spark.ui.proxyBase)") {
+
+ val proxyBaseBeforeTest = System.getProperty("spark.ui.proxyBase")
+ val uiRoot = "/testwebproxybase"
+ System.setProperty("spark.ui.proxyBase", uiRoot)
--- End diff --
Do you need to use system properties for this? Isn't it enough to set it in
`SparkConf`?
If you need to use system properties, you should use
`ResetSystemProperties` since if your test fails, it will leave the modified
system properties behind.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
