Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15743#discussion_r86604523
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala ---
    @@ -54,7 +54,12 @@ class TaskInfo(
        * accumulable to be updated multiple times in a single task or for two 
accumulables with the
        * same name but different IDs to exist in a task.
        */
    -  val accumulables = ListBuffer[AccumulableInfo]()
    +  lazy val accumulables: ListBuffer[AccumulableInfo] = 
ListBuffer(_accumulables: _*)
    --- End diff --
    
    Meh, kind of a toss-up. My original patch broke compatibility and I did 
this in 4c867f10ff5d8d80c7e8d44b4702785c0a017b64 to restore binary 
compatibility, but it risks changing semantics. I think I'll just revert 
4c867f10ff5d8d80c7e8d44b4702785c0a017b64 and add the minor compatibility break 
to a lesser-used `@DeveloperAPI`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to