Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15743#discussion_r86842160
  
    --- Diff: project/MimaExcludes.scala ---
    @@ -86,7 +86,10 @@ object MimaExcludes {
           // [SPARK-18034] Upgrade to MiMa 0.1.11 to fix flakiness.
           
ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("org.apache.spark.ml.param.shared.HasAggregationDepth.aggregationDepth"),
           
ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("org.apache.spark.ml.param.shared.HasAggregationDepth.getAggregationDepth"),
    -      
ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("org.apache.spark.ml.param.shared.HasAggregationDepth.org$apache$spark$ml$param$shared$HasAggregationDepth$_setter_$aggregationDepth_=")
    +      
ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("org.apache.spark.ml.param.shared.HasAggregationDepth.org$apache$spark$ml$param$shared$HasAggregationDepth$_setter_$aggregationDepth_="),
    +
    +      // [SPARK-18236] Reduce duplicate objects in Spark UI and 
HistoryServer
    +      
ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.scheduler.TaskInfo.accumulables")
    --- End diff --
    
    Yep, that's intentional; we removed the logic for excluding that annotation 
in #11751. The rationale is discussed in 
https://issues.apache.org/jira/browse/SPARK-13920:
    
    > Our MIMA binary compatibility checks currently ignore APIs which are 
marked as `@Experimental`or `@DeveloperApi`, but I don't think this makes 
sense. Even if those annotations _reserve_ the right to break binary 
compatibility, we should still avoid compatibility breaks whenever possible and 
should be informed explicitly when compatibility breaks.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to