Github user vijoshi commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15742#discussion_r86711698
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
    @@ -143,6 +143,12 @@ class HistoryServer(
         appCache.stop()
       }
     
    +  // For testing - override stop timeout used by jetty
    +  private[history] def setStopTimeout(timeout: Long): Unit = {
    --- End diff --
    
    this was 30 secs additional for just the one test i added. if more such 
tests are added the time would add up - so i felt the option to bypass the wait 
was useful to have. assuming more of the UI could transition to ajax etc I 
could move this utility function up into the base `WebUI` class so it's 
available more generally for future UI tests - not just history server?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to