Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/15779
@sethah @yanboliang I just saw your PRs for SPARK-17748. Awesome change.
I just saw a few nits along the way.
The only major item is making SingularMatrixException private ml. This
would be the first public Exception type we have in MLlib, I believe. If it is
to be public, I'd prefer it live in spark.ml.linalg, so we could move it there
instead of making it private.
Also, I'm not a big fan of using Exceptions to handle logic. I'd prefer to
change the use of CholeskySolver to pass the failure code, rather than relying
on exceptions. If that sounds good to you, then I'll make a follow up JIRA for
it.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
