Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15763#discussion_r86859677
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1044,6 +1044,34 @@ class Analyzer(
failOnOuterReference(p)
p
}
+
+ // SPARK-17348
+ // Looking for a potential incorrect result case.
+ // When a correlated predicate is a non-equality predicate
+ // it must be placed at the immediate child operator.
+ // Otherwise, the pull up of the correlated predicate
+ // will generate a plan with a different semantics
+ // which could return incorrect result.
+ var continue : Boolean = true
+ for (pm <- predicateMap if continue) {
+ assert(pm._2.nonEmpty, "Correlated predicate(s) does not exist.")
+ for (p <- pm._2 if continue)
+ p match {
+ case EqualTo(_, _) | EqualNullSafe(_, _) =>
+ None
+ case _ =>
+ assert(transformed.children.nonEmpty)
+ if (!(transformed.isInstanceOf[Project]) ||
--- End diff --
Do you think we can put this in the previous block? That might be easier.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
