Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/15148
> The current implementation is equivalent to the L = 1 case always, and
outputDim corresponds to d.
That is true if you're talking about comparing hash values. But for approx
similarity and nearest neighbors, this is doing d = 1 and L = outputDim (i.e.,
OR amplification). (Did you swap accidentally?) Definitely need to clarify in
the docs.
I'm not too worried about making ```randUnitVectors``` private. We can
always deprecate it and have it throw an exception when it is not applicable.
I'm more worried about the schema for transform(). Do you think we should
go ahead and output a Matrix so we can support AND and OR in the future?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
