Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/15148
Oh and for naming - I'm ok with the current ones actually. However we could
think about changing to `ScalarRandomProjectionLSH` (a term mentioned in
@karlhigley's package), as later we will have `SignRandomProjectionLSH` for
cosine distance; and `MinHashLSH`, etc - just to make it clear what the class
is doing. (perhaps later we have some other random projection algorithm that
conflicts etc).
We could name according to the estimated metric such as `EuclideanLSH` or
so on, but if we want to support say Euclidean and Manhattan distance at some
point that becomes problematic. So perhaps best not to?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
