Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r87525740
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -43,11 +43,38 @@ trait ExpressionEvalHelper extends
GeneratorDrivenPropertyChecks {
protected def checkEvaluation(
expression: => Expression, expected: Any, inputRow: InternalRow =
EmptyRow): Unit = {
- val catalystValue = CatalystTypeConverters.convertToCatalyst(expected)
+ // No codegen version expects GenericArrayData for array expect
Binarytype
+ val catalystValue = expected match {
+ case arr: Array[Byte] if expression.dataType == BinaryType => arr
+ case arr: Array[_] => new
GenericArrayData(arr.map(CatalystTypeConverters.convertToCatalyst))
--- End diff --
Doesn't this line do the same what
`CatalystTypeConverters.convertToCatalyst` does?
I don't see `convertToCatalyst` do special case for `BinaryType` before.
Why we need to do that now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
