Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r87685165
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -43,11 +43,38 @@ trait ExpressionEvalHelper extends
GeneratorDrivenPropertyChecks {
protected def checkEvaluation(
expression: => Expression, expected: Any, inputRow: InternalRow =
EmptyRow): Unit = {
- val catalystValue = CatalystTypeConverters.convertToCatalyst(expected)
+ // No codegen version expects GenericArrayData
+ val catalystValue = expected match {
--- End diff --
This is still looks weird to me.
Actually you need this because you replace `Seq` with `Array` in
`test("CreateArray")` at `ComplexTypeSuite.scala`.
Can we not change `Seq` to `Array` in `ComplexTypeSuite`? We actually can
convert `Seq` to `Array` for unsafe version only in `convertToCatalystUnsafe`
if we move `convertToCatalystUnsafe` to `ExpressionEvalHelper.scala`.
No other place uses this `convertToCatalystUnsafe`, I think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
