Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15659#discussion_r87680011
--- Diff: dev/create-release/release-build.sh ---
@@ -162,14 +162,35 @@ if [[ "$1" == "package" ]]; then
export ZINC_PORT=$ZINC_PORT
echo "Creating distribution: $NAME ($FLAGS)"
+ # Write out the NAME and VERSION to PySpark version info we rewrite
the - into a . and SNAPSHOT
+ # to dev0 to be closer to PEP440. We use the NAME as a "local version".
+ PYSPARK_VERSION=`echo "$SPARK_VERSION+$NAME" | sed -r "s/-/./" | sed
-r "s/SNAPSHOT/dev0/"`
+ echo "__version__='$PYSPARK_VERSION'" > python/pyspark/version.py
+
# Get maven home set by MVN
MVN_HOME=`$MVN -version 2>&1 | grep 'Maven home' | awk '{print $NF}'`
+ echo "Creating distribution"
./dev/make-distribution.sh --name $NAME --mvn $MVN_HOME/bin/mvn --tgz
$FLAGS \
-DzincPort=$ZINC_PORT 2>&1 > ../binary-release-$NAME.log
cd ..
- cp spark-$SPARK_VERSION-bin-$NAME/spark-$SPARK_VERSION-bin-$NAME.tgz .
+ echo "Copying and signing python distribution"
+ PYTHON_DIST_NAME=pyspark-$PYSPARK_VERSION.tar.gz
--- End diff --
We shouldn't port the release bash scripts to Windows. It's going to be a
huge pain with little obvious benefit. Windows users who want to make release
builds can just run this version of the script in a `*nix` VM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
