Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15659#discussion_r87678665
--- Diff: dev/run-pip-tests-2 ---
@@ -0,0 +1,105 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Stop on error
+set -e
+# Set nullglob for when we are checking existence based on globs
+shopt -s nullglob
+
+FWDIR="$(cd "`dirname $0`"/..; pwd)"
+cd "$FWDIR"
+# Some systems don't have pip or virtualenv - in those cases our tests
won't work.
+if ! hash virtualenv 2>/dev/null; then
+ echo "Missing virtualenv skipping pip installability tests."
+ exit 0
+fi
+if ! hash pip 2>/dev/null; then
+ echo "Missing pip, skipping pip installability tests."
+ exit 0
+fi
+
+# Figure out which Python execs we should test pip installation with
+PYTHON_EXECS=()
+if hash python 2>/dev/null; then
+ # We do this since we are testing with virtualenv and the default
virtual env python
+ # is in /usr/bin/python
+ PYTHON_EXECS+=('python')
+fi
+if hash python3 2>/dev/null; then
+ PYTHON_EXECS+=('python3')
+fi
+
+echo "Constucting virtual env for testing"
+mktemp -d > ./virtual_env_temp_dir
+VIRTUALENV_BASE=`cat ./virtual_env_temp_dir`
+
+# Determine which version of PySpark we are building for archive name
+PYSPARK_VERSION=`python -c
"exec(open('python/pyspark/version.py').read());print __version__"`
+PYSPARK_DIST="$FWDIR/python/dist/pyspark-$PYSPARK_VERSION.tar.gz"
+# The pip install options we use for all the pip commands
+PIP_OPTIONS="--upgrade --no-cache-dir --force-reinstall "
+# Test both regular user and edit/dev install modes.
+PIP_COMMANDS=("pip install $PIP_OPTIONS $PYSPARK_DIST"
+ "pip install $PIP_OPTIONS -e python/")
+
+for python in "${PYTHON_EXECS[@]}"; do
+ for install_command in "${PIP_COMMANDS[@]}"; do
+ echo "Testing pip installation with python $python"
+ # Create a temp directory for us to work in and save its name to a
file for cleanup
+ echo "Using $VIRTUALENV_BASE for virtualenv"
+ VIRTUALENV_PATH=$VIRTUALENV_BASE/$python
+ rm -rf $VIRTUALENV_PATH
+ mkdir -p $VIRTUALENV_PATH
+ virtualenv --python=$python $VIRTUALENV_PATH
+ source $VIRTUALENV_PATH/bin/activate
+ # Upgrade pip
+ pip install --upgrade pip
+
+ echo "Creating pip installable source dist"
+ cd $FWDIR/python
--- End diff --
I think we need double quotes here and around the other substitutions in
this file to avoid problems for folks with spaces in their directory names.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
