Github user anabranch commented on a diff in the pull request:
https://github.com/apache/spark/pull/15815#discussion_r87699964
--- Diff: R/pkg/R/DataFrame.R ---
@@ -936,7 +936,9 @@ setMethod("unique",
#' Sample
#'
-#' Return a sampled subset of this SparkDataFrame using a random seed.
+#' Return a sampled subset of this SparkDataFrame using a random seed.
+#' Note that this is not guaranteed to provide exactly the fraction
specified
--- End diff --
Yeah I see what you're saying but I think it might be a bit out of scope
for this PR. What your goal is definitely makes sense as there should be a
standard, but I don't think I'm degrading anything significantly. I will add
the `:` character.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
