Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15820#discussion_r88366565
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaConsumer.scala
---
@@ -47,40 +51,229 @@ private[kafka010] case class CachedKafkaConsumer
private(
/** Iterator to the already fetch data */
private var fetchedData =
ju.Collections.emptyIterator[ConsumerRecord[Array[Byte], Array[Byte]]]
- private var nextOffsetInFetchedData = -2L
+ private var nextOffsetInFetchedData = UNKNOWN_OFFSET
/**
* Get the record for the given offset, waiting up to timeout ms if IO
is necessary.
* Sequential forward access will use buffers, but random access will be
horribly inefficient.
+ *
+ * If `failOnDataLoss` is `false`, it will try to get the earliest
record in
+ * `[offset, untilOffset)` when some illegal state happens. Otherwise,
an `IllegalStateException`
--- End diff --
"Otherwise" means, when failOnDataLoss is false but not some illegal state?
its confusing.
Rather just rewrite it as
When `failOnDataLoss` is `true`, this will either return record at offset
if available, or throw exception.
When `failOnDataLoss` is `false`, this will either return record at offset
if available, or return the next earliest available record < untilOffset, or
null. It will not throw any exception.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
