Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15820#discussion_r88758179
  
    --- Diff: 
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaConsumer.scala
 ---
    @@ -47,40 +51,191 @@ private[kafka010] case class CachedKafkaConsumer 
private(
     
       /** Iterator to the already fetch data */
       private var fetchedData = 
ju.Collections.emptyIterator[ConsumerRecord[Array[Byte], Array[Byte]]]
    -  private var nextOffsetInFetchedData = -2L
    +  private var nextOffsetInFetchedData = UNKNOWN_OFFSET
     
       /**
        * Get the record for the given offset, waiting up to timeout ms if IO 
is necessary.
    --- End diff --
    
    nit: update docs to clarify earlier that this may not return offset 
    Get the record for the given offset if available. Otherwise it will either 
throw error (if failOnDataLoss = true), or return the next available offset 
within [offset, untilOffset].
    
    Use @param to explain pollTimeoutMs and others in more detail
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to