Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15956#discussion_r88977868
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -388,6 +388,26 @@ abstract class BinaryComparison extends BinaryOperator
with Predicate {
defineCodeGen(ctx, ev, (c1, c2) => s"${ctx.genComp(left.dataType,
c1, c2)} $symbol 0")
}
}
+
+ // The type checking logic of BinaryComparison can't be expressed by
`inputType`, so we use
+ // AnyDataType here to bypass this check, and implement the actual type
checking logic in
+ // `checkInputDataTypes`
+ override def inputType: AbstractDataType = AnyDataType
+
+ // TODO: although map type is not orderable, technically map type should
be able to be used
+ // in equality comparison, update this type check once we support it.
+ override def checkInputDataTypes(): TypeCheckResult = {
+ super.checkInputDataTypes() match {
+ case TypeCheckResult.TypeCheckSuccess =>
+ if (RowOrdering.isOrderable(left.dataType)) {
--- End diff --
Semantically, this is different from the previous lilmits:
```
override def inputType: AbstractDataType = TypeCollection.Ordered
```
We add the support of `StructType`, `ArrayType` and `UDT`. It sounds like
no test case coverage. Could you please add them?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
