Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15956#discussion_r89119453
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -183,21 +183,6 @@ trait CheckAnalysis extends PredicateHelper {
s"join condition '${condition.sql}' " +
s"of type ${condition.dataType.simpleString} is not a
boolean.")
- case j @ Join(_, _, _, Some(condition)) =>
- def checkValidJoinConditionExprs(expr: Expression): Unit =
expr match {
- case p: Predicate =>
-
p.asInstanceOf[Expression].children.foreach(checkValidJoinConditionExprs)
- case e if e.dataType.isInstanceOf[BinaryType] =>
--- End diff --
We should add a few tests with binary keys, that can also be done in a
follow-up. The parser supports binary literals, so we can use
`SQLQueryTestSuite` for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
