Github user ZakariaHili commented on a diff in the pull request:
https://github.com/apache/spark/pull/15965#discussion_r89108412
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -306,12 +307,18 @@ class KMeans @Since("1.5.0") (
@Since("2.0.0")
override def fit(dataset: Dataset[_]): KMeansModel = {
+ val handlePersistence = dataset.rdd.getStorageLevel ==
StorageLevel.NONE
+ fit(dataset, handlePersistence)
+ }
+ protected def fit(dataset: Dataset[_], handlePersistence: Boolean):
KMeansModel = {
--- End diff --
@srowen ,If I understand, you want something like this :
@ Since("2.2.0")
override def fit(dataset: Dataset[_]): KMeansModel = {
val handlePersistence = dataset.rdd.getStorageLevel == StorageLevel.NONE
fit(dataset, handlePersistence)
}
@ Since("2.2.0")
protected def fit(dataset: Dataset[_], handlePersistence: Boolean):
KMeansModel = {
transformSchema(dataset.schema, logging = true)
val instances: RDD[OldVector] =
dataset.select(col($(featuresCol))).rdd.map {
case Row(point: Vector) => OldVectors.fromML(point)
}
update since 2.0.0 to 2.2.0 and i have to add a space between those two
methods.
is that right ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
