Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15965#discussion_r89129561
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -304,14 +305,21 @@ class KMeans @Since("1.5.0") (
@Since("1.5.0")
def setSeed(value: Long): this.type = set(seed, value)
- @Since("2.0.0")
+ @Since("2.2.0")
override def fit(dataset: Dataset[_]): KMeansModel = {
+ val handlePersistence = dataset.rdd.getStorageLevel ==
StorageLevel.NONE
+ fit(dataset, handlePersistence)
+}
+ @Since("2.2.0")
--- End diff --
There is still no blank line above this line -- not sure how else to
express this?
The indentation of the line above is off too.
Look, you should match the style you see around this code, and you can see
how it isn't the same? just make it match.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
