Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15949#discussion_r89237316
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
 ---
    @@ -38,6 +40,27 @@ import org.apache.spark.sql.streaming._
     import org.apache.spark.util.{Clock, UninterruptibleThread, Utils}
     
     /**
    + * Contains metadata associated with a stream execution. This information 
is
    + * persisted to the offset log via the OffsetSeq metadata field. Current
    + * information contained in this object includes:
    + *
    + * @param currentEventTimeWatermarkMillis: The current eventTime 
watermark, used to
    + * bound the lateness of data that will processed. Time unit: milliseconds
    + * @param currentBatchTimestampMillis: The current batch processing 
timestamp.
    + * Time unit: milliseconds
    + */
    +case class StreamExecutionMetadata(
    +    var currentEventTimeWatermarkMillis: Long = 0,
    --- End diff --
    
    nit: this is pretty long! how about just `batchWatermarkMs`, and 
`batchTimestampMs`. Its not really current if a batch is being reprocessed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to