Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15949#discussion_r89239675
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -422,6 +450,12 @@ class StreamExecution(
val replacementMap = AttributeMap(replacements)
val triggerLogicalPlan = withNewSources transformAllExpressions {
case a: Attribute if replacementMap.contains(a) => replacementMap(a)
+ case ct: CurrentTimestamp =>
+
CurrentBatchTimestamp(streamExecutionMetadata.currentBatchTimestampMillis,
+ ct.dataType)
+ case cd: CurrentDate =>
+
CurrentBatchTimestamp(streamExecutionMetadata.currentBatchTimestampMillis,
--- End diff --
NVM!!!! I MISSED THE conversion inside `CurrentBatchTimeStamp.toLiteral`.
MY BAD!!
But then there are not tests for current_date! So one of the branch in the
above code is not being tested at all.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
