Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15913#discussion_r89368387
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeModels.scala ---
@@ -95,11 +95,6 @@ private[ml] trait TreeEnsembleModel[M <:
DecisionTreeModel] {
/** Trees in this ensemble. Warning: These have null parent Estimators.
*/
def trees: Array[M]
- /**
- * Number of trees in ensemble
- */
- val getNumTrees: Int = trees.length
--- End diff --
This is a headache. Before, `getNumTrees` on gbts/rfs would dispatch here.
Now, we removed `numTrees` from RF (it was deprecated) and so now we can have
rf inherit from `RandomForestParams` which (now) has a param `numTrees` and its
associated getter. So if we hadn't removed this, rf would have two
`getNumTrees` methods and one would take precedence. We removed it from here to
avoid that, then we had to add them back in the individual GBT subclasses. I
think I've got that right.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
