Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15913#discussion_r89442550
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -176,8 +176,12 @@ private[classification] trait LogisticRegressionParams
extends ProbabilisticClas
}
}
- override def validateParams(): Unit = {
+ override protected def validateAndTransformSchema(
--- End diff --
I think it's a bug that ```validateParams ``` was never used. It should
validate params interaction before fitting(if necessary), this is why we
deprecate ```validateParams ``` and move what it does to ```transformSchema```.
We do not have corresponding test cases before, so no test was broken when we
deprecated ```validateParams```. I added test cases in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
