Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16014#discussion_r89677001
  
    --- Diff: dev/create-release/release-build.sh ---
    @@ -189,6 +189,9 @@ if [[ "$1" == "package" ]]; then
           SHA512 $PYTHON_DIST_NAME > \
           $PYTHON_DIST_NAME.sha
     
    +    echo "Copying R source package"
    +    cp spark-$SPARK_VERSION-bin-$NAME/R/SparkR_$SPARK_VERSION.tar.gz .
    --- End diff --
    
    Thanks @srowen for asking. I've updated the PR description above.
    
    "
    This PR has 2 key changes. One, we are building source package (aka bundle 
package) for SparkR which could be released on CRAN. Two, we should include in 
the official Spark binary distributions SparkR installed from this source 
package instead (which would have help/vignettes rds needed for those to work 
when the SparkR package is loaded in R, whereas earlier approach with devtools 
does not)
    "


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to