Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16014#discussion_r89912555
--- Diff: dev/make-distribution.sh ---
@@ -208,11 +212,24 @@ cp -r "$SPARK_HOME/data" "$DISTDIR"
# Make pip package
if [ "$MAKE_PIP" == "true" ]; then
echo "Building python distribution package"
- cd $SPARK_HOME/python
+ pushd "$SPARK_HOME/python" > /dev/null
python setup.py sdist
- cd ..
+ popd > /dev/null
+else
+ echo "Skipping building python distribution package"
+fi
+
+# Make R package - this is used for both CRAN release and packing R layout
into distribution
+if [ "$MAKE_R" == "true" ]; then
+ echo "Building R source package"
+ pushd "$SPARK_HOME/R" > /dev/null
+ # Build source package and run full checks
+ # Install source package to get it to generate vignettes, etc.
+ # Do not source the check-cran.sh - it should be run from where it is
for it to set SPARK_HOME
+ NO_TESTS=1 CLEAN_INSTALL=1 "$SPARK_HOME/"R/check-cran.sh
--- End diff --
I agree. I think it is somewhat debatable whether we should run `R CMD
check` in `make-distribution.sh` - but I feel there are gaps with what we check
in Jenkins that it is worthwhile to repeat that here.
For everything else it's just convenient to call R from here. We could
factor out the R environment stuff and have a separate `install.sh` (possibly
replacing `install-dev.sh` since this does more with the source package? What
do you think?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
