Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16013#discussion_r89686342
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala 
---
    @@ -366,13 +366,13 @@ object PrefixSpan extends Logging {
        * Items are represented by positive integers, and items in each itemset 
must be distinct and
        * ordered.
        * we use 0 as the delimiter between itemsets.
    -   * For example, a sequence `<(12)(31)1>` is represented by `[0, 1, 2, 0, 
1, 3, 0, 1, 0]`.
    -   * The postfix of this sequence w.r.t. to prefix `<1>` is `<(_2)(13)1>`.
    +   * For example, a sequence &lt;(12)(31)1&gt; is represented by `[0, 1, 
2, 0, 1, 3, 0, 1, 0]`.
    +   * The postfix of this sequence w.r.t. to prefix &lt;1&gt; is 
&lt;(_2)(13)1&gt;.
        * We may reuse the original items array `[0, 1, 2, 0, 1, 3, 0, 1, 0]` 
to represent the postfix,
        * and mark the start index of the postfix, which is `2` in this example.
        * So the active items in this postfix are `[2, 0, 1, 3, 0, 1, 0]`.
        * We also remember the start indices of partial projections, the ones 
that split an itemset.
    -   * For example, another possible partial projection w.r.t. `<1>` is 
`<(_3)1>`.
    +   * For example, another possible partial projection w.r.t. &lt;1&gt; is 
&lt;(_3)1&gt;.
    --- End diff --
    
    I would just remove the angle brackets. I don't see that they add anything.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to