Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89686160
--- Diff: core/src/main/scala/org/apache/spark/rdd/DoubleRDDFunctions.scala
---
@@ -152,10 +152,12 @@ class DoubleRDDFunctions(self: RDD[Double]) extends
Logging with Serializable {
/**
* Compute a histogram using the provided buckets. The buckets are all
open
- * to the right except for the last which is closed
+ * to the right except for the last which is closed.
+ * {{{
* e.g. for the array
* [1, 10, 20, 50] the buckets are [1, 10) [10, 20) [20, 50]
* e.g 1<=x<10 , 10<=x<20, 20<=x<=50
+ * }}}
--- End diff --
Why put the whole section as code? it's just the portion with several
inequalities. Can those be back-tick-escaped? Or is the point that the
back-ticks don't work? does `{@code ...}` work with < / > ?
BTW, very minor, but the second "e.g" misses a period. "e.g." isn't really
great either. You could expand the first to "For example" and the second to
"that is", which was really what was meant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
