Github user nsyca commented on the issue:
https://github.com/apache/spark/pull/16044
@hvanhovell Thank you for the detailed instruction on the test case.
@gatorsmile Also thanks for the directive.
In addition to the white box testing on the Optimized Logical Plan, I also
added two black box test cases in `org.apache.spark.sql.JoinSuite`. Hopefully
it's a right place to put.
This is just to share my experience: The good thing about writing white box
test cases, such as doing plan comparison as in
`org.apache.spark.sql.catalyst.optimizer._`, are good in verifying internal
behaviour, such as whether an optimization does happen or not. It may also
catch problems that are not exposed externally. However, the down side is
writing white box test cases are more time-consuming and more sensitive to
future code changes. It could create a huge cost of test cases maintenance in
the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
