Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r90190203
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoderSuite.scala
---
@@ -338,6 +338,18 @@ class ExpressionEncoderSuite extends PlanTest with
AnalysisTest {
}
}
+ test("nullable of encoder serializer") {
+ def checkNullable[T: Encoder](nullable: Boolean*): Unit = {
--- End diff --
this is over design, we only pass a single parameter, or are you going to
add some more non-flat cases?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
