Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r90193978
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -590,7 +591,11 @@ object ScalaReflection extends ScalaReflection {
"cannot be used as field name\n" +
walkedTypePath.mkString("\n"))
}
- val fieldValue = Invoke(inputObject, fieldName,
dataTypeFor(fieldType))
+ // primitive take only non-null or struct takes non-null object
guarded by isNull
--- End diff --
+1
`Option[Int]`, `Option[String]`, `Option[Tuple1[Int]]`,
`Option[Tuple1[String]]` are ok?
If so I'd like you to add the following tests to `ExpressionEncoderSuite`:
```scala
encodeDecodeTest(Option(31), "option of int")
encodeDecodeTest(Option("abc"), "option of string")
encodeDecodeTest(Option.empty[Int], "empty option of int")
encodeDecodeTest(Option.empty[String], "empty option of string")
encodeDecodeTest(Option(Tuple1(31)), "option of tuple1 of int")
encodeDecodeTest(Option.empty[Tuple1[Int]], "empty option of tuple1 of int")
encodeDecodeTest(Option(Tuple1("abc")), "option of tuple1 of string")
encodeDecodeTest(Option.empty[Tuple1[String]], "empty option of tuple1 of
string")
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
