Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16090#discussion_r90580481
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
 ---
    @@ -58,13 +58,21 @@ case class CreateDataSourceTableCommand(table: 
CatalogTable, ignoreIfExists: Boo
         // Create the relation to validate the arguments before writing the 
metadata to the metastore,
         // and infer the table schema and partition if users didn't specify 
schema in CREATE TABLE.
         val pathOption = table.storage.locationUri.map("path" -> _)
    +    // Fill in some default table options from the session conf
    +    val uncreatedTable = table.copy(
    +      identifier = table.identifier.copy(
    +        database = Some(
    +          
table.identifier.database.getOrElse(sessionState.catalog.getCurrentDatabase))),
    +      tracksPartitionsInCatalog = 
sparkSession.sessionState.conf.manageFilesourcePartitions)
         val dataSource: BaseRelation =
           DataSource(
             sparkSession = sparkSession,
             userSpecifiedSchema = if (table.schema.isEmpty) None else 
Some(table.schema),
    +        partitionColumns = table.partitionColumnNames,
             className = table.provider.get,
             bucketSpec = table.bucketSpec,
    -        options = table.storage.properties ++ pathOption).resolveRelation()
    +        options = table.storage.properties ++ pathOption,
    +        catalogTable = Some(uncreatedTable)).resolveRelation()
    --- End diff --
    
    why we need to pass in the `catalogTable` here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to