Github user ericl commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16090#discussion_r90582300
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala 
---
    @@ -312,7 +312,13 @@ class DDLSuite extends QueryTest with SharedSQLContext 
with BeforeAndAfterEach {
               pathToNonPartitionedTable,
               userSpecifiedSchema = Option("num int, str string"),
               userSpecifiedPartitionCols = partitionCols,
    -          expectedSchema = new StructType().add("num", 
IntegerType).add("str", StringType),
    +          expectedSchema = if (partitionCols.isDefined) {
    --- End diff --
    
    I think that would be testing something slightly different.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to