Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13579#discussion_r91427614
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
@@ -289,6 +289,30 @@ object HistoryServer extends Logging {
while(true) { Thread.sleep(Int.MaxValue) }
}
+ /**
+ * Create a security manager.
+ * This includes any fixup of the configurations needed to produce a
security manager
+ * capable of starting the History Server.
+ * @param config configuration for the SecurityManager constructor
+ * @return
+ */
+ private[history] def createSecurityManager(config: SparkConf):
SecurityManager = {
+ patchSecuritySettings(config)
+ new SecurityManager(config)
+ }
+
+ /**
+ * Fix up the configuration of a spark configuration so that the
security manager will
+ * always start.
+ * @param config configuration to be used in a SecurityManager
constructor
+ */
+ private def patchSecuritySettings(config: SparkConf): Unit = {
--- End diff --
Could you just inline this method? That avoids adding a method with a
single call, and pretty much a copy of the whole scaladoc of the other method
you're adding.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
