Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/13579#discussion_r91546575
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala ---
@@ -349,6 +349,17 @@ class HistoryServerSuite extends SparkFunSuite with
BeforeAndAfter with Matchers
}
+ /**
+ * Verify that the security manager needed for the history server can be
instantiated
+ * even if spark.authenticate is set
+ */
+ test("SecurityManagerStartsWithSecureShuffle") {
+ val conf = new SparkConf()
+ .set("spark.testing", "true")
+ .set(SecurityManager.SPARK_AUTH_CONF, "true")
+ HistoryServer.createSecurityManager(conf)
--- End diff --
done. You know, this test could be merged into `"incomplete apps get
refreshed"`, just by setting the security option and mentioning why it matters
in a comment. I've patched that test to also use
`HistoryServer.createSecurityManager` for consistency. it would save a
fractional amount of test time
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
