Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16219#discussion_r91781665
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/FileStreamSinkLogSuite.scala
---
@@ -151,10 +151,11 @@ class FileStreamSinkLogSuite extends SparkFunSuite
with SharedSQLContext {
testWithUninterruptibleThread("delete expired file") {
// Set FILE_SINK_LOG_CLEANUP_DELAY to 0 so that we can detect the
deleting behaviour
- // deterministically
+ // deterministically and one min batches to retain
withSQLConf(
SQLConf.FILE_SINK_LOG_COMPACT_INTERVAL.key -> "3",
- SQLConf.FILE_SINK_LOG_CLEANUP_DELAY.key -> "0") {
+ SQLConf.FILE_SINK_LOG_CLEANUP_DELAY.key -> "0",
+ SQLConf.MIN_BATCHES_TO_RETAIN.key -> "1") {
--- End diff --
Could you also test other value of `SQLConf.MIN_BATCHES_TO_RETAIN`? Testing
only 1 is not enough.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
