Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16219#discussion_r91780225
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala
---
@@ -215,21 +219,32 @@ abstract class CompactibleFileStreamLog[T <: AnyRef :
ClassTag](
* S3, the compaction file may not be seen by other processes at once.
So we only delete files
* created `fileCleanupDelayMs` milliseconds ago.
*/
- private def deleteExpiredLog(compactionBatchId: Long): Unit = {
- val expiredTime = System.currentTimeMillis() - fileCleanupDelayMs
- fileManager.list(metadataPath, new PathFilter {
- override def accept(path: Path): Boolean = {
- try {
- val batchId = getBatchIdFromFileName(path.getName)
- batchId < compactionBatchId
- } catch {
- case _: NumberFormatException =>
- false
+ private def deleteExpiredLog(currentBatchId: Long): Unit = {
--- End diff --
Could you also update the comments since they are out of date?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
