Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16137#discussion_r91855189
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -705,13 +712,17 @@ class SparkContext(config: SparkConf) extends Logging 
{
     
       // Methods for creating RDDs
     
    -  /** Distribute a local Scala collection to form an RDD.
    +  /**
    +   * Distribute a local Scala collection to form an RDD.
        *
        * @note Parallelize acts lazily. If `seq` is a mutable collection and 
is altered after the call
        * to parallelize and before the first action on the RDD, the resultant 
RDD will reflect the
        * modified collection. Pass a copy of the argument to avoid this.
        * @note avoid using `parallelize(Seq())` to create an empty `RDD`. 
Consider `emptyRDD` for an
        * RDD with no partitions, or `parallelize(Seq[T]())` for an RDD of `T` 
with empty partitions.
    +   * @param seq Scala collection to distribute
    +   * @param numSlices how many sub-collections should it be sliced into
    --- End diff --
    
    numSlices is a legacy name. Although the name must be kept its doc should 
refer to "partitions". How about "number of partitions to divide collection 
into"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to