Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16137#discussion_r91950169
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1038,6 +1059,13 @@ class SparkContext(config: SparkConf) extends
Logging {
* operation will create many references to the same object.
* If you plan to directly cache, sort, or aggregate Hadoop writable
objects, you should first
* copy them using a `map` function.
+ * @param path directory to the input data files, the path can be comma
separated paths
+ * as a list of inputs
+ * @param minPartitions suggested minimum number of partitions for the
resulting RDD
+ * @param km implicitly found Class of the key associated with the `fm`
implicit parameter
--- End diff --
The thing is that callers won't be specifying these. They're just an
implementation detail related to various generic types. If anything, it's the
generic types that should be documented, though they're kind of obvious.
These things aren't Classes, but ClassTags. fm is the parameter; it's not
something related to fm. Really, fm is related to F.
If this is all we can say about these types I'd remove them, because I'm
not sure anyone who doesn't already understand implicit ClassTags is going to
be helped by this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
