Github user Mironor commented on the issue:
https://github.com/apache/spark/pull/16137
@srowen
> I don't think most of my comment were addressed. This will be easier if
you try to respond to each of them and apply them across your change at each
round.
I genuinely would like to know which ones. I removed obvious javadocs (with
the exception of `uiWebUrl` because I misunderstood you), indentation,
upper-casing and applied suggested modifications to all the comments in this
PR.
I also don't know if I should reply to everyone fo your comments or if it's
just ok to apply the modification (so that the comment would be "collapsed"
after the push).
> Otherwise, for a relatively minor change this takes a lot of bandwidth.
I could remove the difference below a certain line to make this PR more
lightweight.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
