Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/16137
  
    Yes I'm referring to 
    https://github.com/apache/spark/pull/16137#discussion_r90948858
    
    and to some extent these issues remain in some form, though it's a judgment 
call:
    https://github.com/apache/spark/pull/16137#discussion_r90948903
    https://github.com/apache/spark/pull/16137#discussion_r91170210
    
    Given the sense of the feedback I think you can probably extrapolate what 
of this is clearly useful and what probably isn't worth it. If you can take 
your best shot at applying that to the whole change then I'll have another look.
    
    No, don't split up the PR. I just meant that it wouldn't be useful to make 
20 variations of the same comments if you can just run with them and apply to 
the rest first.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to