Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16258#discussion_r92067753
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
 ---
    @@ -360,6 +360,24 @@ class StreamExecution(
         if (hasNewData) {
           // Current batch timestamp in milliseconds
           offsetSeqMetadata.batchTimestampMs = triggerClock.getTimeMillis()
    +      // Update the eventTime watermark if we find one in the plan.
    --- End diff --
    
    I moved this such that the watermark is updated before starting a batch, 
rather than after finishing a batch. This keeps batchWatermarkMs consistent 
with batchTimestampsMs, both are set before starting a batch, and reduces 
complexities in the ProgressReporter.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to